<table cellspacing="0" cellpadding="0" border="0" ><tr><td valign="top" style="font: inherit;"><span style="font-family: courier,monaco,monospace,sans-serif;"></span>Hello everyone<br><br>I've written the following bash script.<br><br>#<br><span style="font-family: courier,monaco,monospace,sans-serif;">for file in *.jpg ; do</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> # creating the thumbnail filename</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> thumbfile="$(basename "$file" .jpg)th.jpg"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family:
courier,monaco,monospace,sans-serif;"> # reading the width and height of the jpg</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> let WIDTH=exiftags $file | grep "Image Width"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> let HEIGHT=exiftags $file | grep "Image Height"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> if [ WIDTH > HEIGHT ] ; then</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> # convert as landscape</span><br style="font-family:
courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> convert -thumbnail 200x150 "$file" thumbnails/"$thumbfile"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> else</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> # convert as portrait</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> convert -thumbnail 150x200 "$file" thumbnails/"$thumbfile"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> fi</span><br style="font-family:
courier,monaco,monospace,sans-serif;"><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;">done</span><br style="font-family: courier,monaco,monospace,sans-serif;">#<br><br>and even though it does what I want (ie create thumbnails of jpg files in the correct landscape/portrait orientation) I get the following errors:-<br><br><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 20: let: 20080720-142448.jpg: syntax error: invalid arithmetic operator (error token is ".jpg")</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 21: let: 20080720-142448.jpg: syntax error: invalid arithmetic operator (error token is ".jpg")</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br>(where line 20 is the 'let WIDTH=exiftags...' line, and 'profam' is the name of
my bash script).<br><br><br><br>I've tried the following changes, which also produces errors.<br><br>1) removed the let<br><span style="font-family: courier,monaco,monospace,sans-serif;"> WIDTH=exiftags $file | grep "Image Width"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> HEIGHT=exiftags $file | grep "Image Height"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br>errors:-<br><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 20: 20080720-142448.jpg: command not found</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 21: 20080720-142448.jpg: command not found</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br><br><br>2) added '$'<br><span style="font-family:
courier,monaco,monospace,sans-serif;"> WIDTH=exiftags $file | grep "Image Width"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> HEIGHT=exiftags $file | grep "Image Height"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> if [ $WIDTH > $HEIGHT ] ; then</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br>errors:-<br><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 20: 20080720-142546.jpg: command not found</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 21: 20080720-142546.jpg: command not found</span><br style="font-family:
courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 23: 1: ambiguous redirect</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br><br><br>3) put the 'let' back in<br> <span style="font-family: courier,monaco,monospace,sans-serif;"> let WIDTH=exiftags $file | grep "Image Width"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> let HEIGHT=exiftags $file | grep "Image Height"</span><br style="font-family: courier,monaco,monospace,sans-serif;"><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;"> if [ $WIDTH > $HEIGHT ] ; then</span><br><br>errors:-<br><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 20: let: 20080720-142546.jpg: syntax
error: invalid arithmetic operator (error token is ".jpg")</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 21: let: 20080720-142546.jpg: syntax error: invalid arithmetic operator (error token is ".jpg")</span><br style="font-family: courier,monaco,monospace,sans-serif;"><span style="font-family: courier,monaco,monospace,sans-serif;">profam: line 23: 1: ambiguous redirect</span><br><br><br>Can anyone see what I'm doing wrong?<br><br>Thanks for any help<br><br>Ron<br><br><br></td></tr></table><br>